Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uses a constant for PAGE_SIZE #2089

Merged
merged 2 commits into from
Nov 5, 2018
Merged

Uses a constant for PAGE_SIZE #2089

merged 2 commits into from
Nov 5, 2018

Conversation

jessopb
Copy link
Member

@jessopb jessopb commented Nov 3, 2018 •
edited
Loading

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Breaking changes (bugfix or feature that introduces breaking changes)
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Fixes

#2059

What is the current behavior?

Channel page displays wrong number of pages to nav to,

What is the new behavior?

Channel page displays the right number of pages

@neb-b
Copy link

neb-b commented Nov 4, 2018

LGTM after updating lbry-redux

@neb-b neb-b merged commit 0b640ff into lbryio:master Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@neb-b neb-b

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jessopb @neb-b