Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to open folder containing the log file rather than roaming folder #2078

Merged
merged 3 commits into from
Oct 31, 2018
Merged

Fix to open folder containing the log file rather than roaming folder #2078

merged 3 commits into from
Oct 31, 2018

Conversation

dyllper
Copy link
Contributor

@dyllper dyllper commented Oct 31, 2018

PR Checklist

Please check all that apply to this PR using "x":

  • [ x ] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • [ x ] I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • [ x ] Bugfix
  • Feature
  • Breaking changes (bugfix or feature that introduces breaking changes)
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Fixes

Issue Number: #1600

What is the current behavior?

Clicking "Open Log Folder" will open the "lbry" folder with "lbrynet" highlighted, rather than opening the "lbrynet" folder which contains the log file.

What is the new behavior?

Clicking "Open Log Folder" will open the "lbrynet" folder that contains the log file.

Other information

@tzarebczan
Copy link
Contributor

hey @dyllper, thanks for submitting this PR! We'll have someone review it shortly. Can you also add a changelog entry for this (see previous entries for format).

Make sure to check out our contributing document.

Once this is merged, can we send you some LBC as appreciation?

@tzarebczan tzarebczan added the hacktoberfest Welcome to Hacktoberfest label Oct 31, 2018
@tzarebczan tzarebczan requested a review from neb-b October 31, 2018 15:08
@lbry-bot lbry-bot assigned neb-b and unassigned neb-b Oct 31, 2018
@dyllper
Copy link
Contributor Author

dyllper commented Oct 31, 2018

@tzarebczan Updated the Changelog! Sorry about that. Missed that section when I was reading through the CONTRIBUTING.md file.

Thank you for the offer of LBC, but that won't be necessary. Just happy to be able to help out!

@tzarebczan
Copy link
Contributor

@dyllper how about a Hacktoberfest t-shirt from LBRY? Just reach out to us at the same address :)

@neb-b
Copy link

neb-b commented Oct 31, 2018

Tested and working good! Thanks @dyllper 🙂

@neb-b neb-b merged commit 3f9a205 into lbryio:master Oct 31, 2018
@dyllper dyllper deleted the fix/open-log-folder branch October 31, 2018 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Welcome to Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants