fixes console log warnings when bid is null or NaN #2010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neb-b
suggested changes
Oct 5, 2018
| @@ -19,7 +19,6 @@ import LicenseType from './internal/license-type'; | |||
| type Props = { | |||
| publish: PublishParams => void, | |||
| filePath: ?string, | |||
| bid: ?number, | |||
There was a problem hiding this comment.
On this, there was duplicate bid: ?number, and bid: number in the same Props {}. I removed the "?maybe" one and checked for errors as I published.
| @@ -170,7 +169,7 @@ class PublishForm extends React.PureComponent<Props> { | |||
| const totalAvailableBidAmount = previousBidAmount + balance; | |||
|
|
|||
| let bidError; | |||
| if (bid === 0) { | |||
| if (!bid) { | |||
There was a problem hiding this comment.
I think there will be a bidError when it's empty if we do this.
jessopb
force-pushed
the
publishWarnings
branch
from
8583379
to
6dbbfe4
Compare
jessopb
force-pushed
the
publishWarnings
branch
from
6dbbfe4
to
e7a3c57
Compare
neb-b
approved these changes
Oct 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.