Support for lbrynet daemon v0.30.0 #1998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eukreign You can make use of |
|
I'll try finishing this up |
neb-b
force-pushed
the
lbrynet30
branch
4 times, most recently
from
bad8907
to
417b81a
Compare
skhameneh
approved these changes
Oct 26, 2018
| @@ -159,7 +159,6 @@ class ChannelSection extends React.PureComponent<Props, State> { | |||
| <FormField | |||
| key="channel" | |||
| type="select" | |||
| tabIndex="1" | |||
There was a problem hiding this comment.
What is this change fixing?
There was a problem hiding this comment.
It wasn't doing anything so I removed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@skhameneh This is ready for a review. @akinwale I would appreciate your eyes too to see if I missed anything else needed for v30.
Editing claims aren't working until lbryio/lbry-sdk#1555 is merged. I think it will work as is. I would like to merge it soon so we can get an RC out and begin testing.
I was able to remove a lot of logic for tracking pending publishes since we can use the new
confirmationsfield. It makes things a lot simpler.Requires lbryio/lbry-redux#79 and lbryio/lbryinc#11 but you can run this branch as is (i'm just pointing at the commits from my PR)