Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add confirmation propmt before sending a transaction. #1525

Merged
merged 3 commits into from
Jun 1, 2018
Merged

Add confirmation propmt before sending a transaction. #1525

merged 3 commits into from
Jun 1, 2018

Conversation

dan1d
Copy link
Contributor

@dan1d dan1d commented May 28, 2018

Closes #947
It adds the feature to prompt a modal before sending a transaction.
Maybe we can add the usd value of the transaction also?

screenshot from 2018-05-28 17-01-57
screenshot from 2018-05-28 17-02-14

@dan1d dan1d mentioned this pull request May 28, 2018
Merged
@neb-b
Copy link

neb-b commented May 30, 2018

This is awesome. I think if we say "Once the transaction is sent, it cannot be reversed." it would be a little more clear.

neb-b
neb-b suggested changes May 30, 2018
View reviewed changes
Copy link

@neb-b neb-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the copy change. Nice work

@dan1d
Copy link
Contributor Author

dan1d commented May 30, 2018

@seanyesmunt Thanks, I've updated the requested text change.

@lbry-bot lbry-bot assigned neb-b and unassigned neb-b Jun 1, 2018
@neb-b neb-b merged commit 5ca1124 into lbryio:master Jun 1, 2018
jessopb pushed a commit that referenced this pull request Jul 15, 2022
@toshokanneko
Remove Premium+ Tiles when Premium+ is active (#1525)
746d321
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neb-b neb-b neb-b approved these changes

Assignees

@neb-b neb-b

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dan1d @neb-b @skhameneh