Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show modal when claiming a reward #1455

Merged
merged 2 commits into from
May 10, 2018
Merged

Conversation

dan1d
Copy link
Contributor

@dan1d dan1d commented May 8, 2018

This fixes PART of the issues reported in #1436
As @tzarebczan reported, this error Uncaught (in promise) Error: Actions may not have an undefined "type" property. Have you misspelled a constant?, the constant ACTIONS.OPEN_MODALS is not defined anymore and it throws that error as the type for an action when dispatching it is undefined:

dispatch({
          type: ACTIONS.OPEN_MODAL,
          data: { modal: MODALS.FIRST_REWARD },
        });

Seems like the code to open modals have been refactored and changed to notifications, as far as I understand.
screenshot from 2018-05-07 22-30-13

@neb-b
Copy link

neb-b commented May 8, 2018

Awesome! Can you update this to use lbry-redux? I just merged your other PR

@dan1d dan1d force-pushed the fix-claiming-reward-modal branch from ddb9360 to 1131efd Compare May 8, 2018 13:14
@dan1d
Copy link
Contributor Author

dan1d commented May 8, 2018

@seanyesmunt Done!, I've also added another modal call to use notifications that was not working before!.

@tzarebczan tzarebczan requested a review from neb-b May 8, 2018 13:20
@lbry-bot lbry-bot assigned neb-b and unassigned neb-b May 8, 2018
@tzarebczan
Copy link
Contributor

Thanks @dan1d ! You fixed #1407 in the process as well!

@dan1d dan1d force-pushed the fix-claiming-reward-modal branch from 1131efd to a4da170 Compare May 8, 2018 22:30
@dan1d
Copy link
Contributor Author

dan1d commented May 8, 2018

Glad to know @tzarebczan!
As requested: changelog Updated.

@neb-b neb-b merged commit 4ef8401 into lbryio:master May 10, 2018
@tzarebczan
Copy link
Contributor

@dan1d please send us an email with this PR and your estimated time spent, thanks again for the contribution! https://lbry.io/faq/tips

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants