Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix files don't display correctly in-app anymore #1434

Merged
merged 4 commits into from
May 4, 2018
Merged

Fix files don't display correctly in-app anymore #1434

merged 4 commits into from
May 4, 2018

Conversation

btzr-io
Copy link
Collaborator

@btzr-io btzr-io commented May 3, 2018

Changes

Fix text/HTML files don't display correctly in-app anymore #1379

Todo

  • Display media element after loading metadata

@btzr-io btzr-io changed the title Viewer fix Fix files don't display correctly in-app anymore May 3, 2018
@btzr-io btzr-io requested a review from neb-b May 3, 2018 18:36
@lbry-bot lbry-bot assigned neb-b and unassigned liamcardenas May 3, 2018
@neb-b
Copy link

neb-b commented May 4, 2018

@btzr-io I see you still have an item under TODO, do you plan to do this?

@btzr-io
Copy link
Collaborator Author

btzr-io commented May 4, 2018

@seanyesmunt What's the appropriate way to handle this?
Should I hide the audio element or just move the loader to the top?

loader

@lbryio lbryio deleted a comment May 4, 2018
@btzr-io
Copy link
Collaborator Author

btzr-io commented May 4, 2018

@seanyesmunt ok it's done. ^^

@kauffj
Copy link
Member

kauffj commented May 4, 2018

FYI @daovist I think you're touching some of the same code as this PR.

(This PR is still good/useful, just flagging so he doesn't duplicate effort.)

@neb-b neb-b merged commit 4e42434 into master May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants