Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save app state when closing to tray #1042

Merged
merged 3 commits into from
Feb 27, 2018
Merged

Save app state when closing to tray #1042

merged 3 commits into from
Feb 27, 2018

Conversation

IGassmann
Copy link
Contributor

No description provided.

@tzarebczan
Copy link
Contributor

@IGassmann working as expected here, tested on Windows and Linux.

Would be nice to have a build because lbry:// hyperlinking doesn't seem to work in dev mode. Do you think that's a quick fix, I can open an issue for it.

Copy link
Contributor

@tzarebczan tzarebczan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a functionality standpoint, but maybe have @seanyesmunt or @liamcardenas review the code as well.

@IGassmann
Copy link
Contributor Author

@tzarebczan it's actually expected that lbry:// deep linking URLs don't work on dev mode. Deep link URLs only work after they have been "announced" to the OS. For example on macOS, this is done with the App descriptor file Info.plist which is only generated on a packaged build and not on a dev build.

I've looked into the double-clicking for the tray icon. The feature is not yet supported on Linux: https://electronjs.org/docs/all#event-double-click-macos-windows

@IGassmann IGassmann requested a review from neb-b February 27, 2018 04:03
@lbry-bot lbry-bot assigned neb-b and unassigned IGassmann Feb 27, 2018
@lbry-bot lbry-bot assigned IGassmann and unassigned neb-b Feb 27, 2018
@neb-b neb-b merged commit b370565 into master Feb 27, 2018
@neb-b neb-b deleted the issue/968 branch February 27, 2018 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants