Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hashids to mask IDs in URL #17

Merged
merged 12 commits into from
Dec 2, 2022
Merged

Use hashids to mask IDs in URL #17

merged 12 commits into from
Dec 2, 2022

Conversation

koolskateguy89
Copy link
Contributor

@koolskateguy89 koolskateguy89 commented Dec 2, 2022

  • Add dependencies
  • Define /lib/hashids
  • Define pepper, i.e. secret salt
    • Wanted to define it as env var but then it's not accessible in ProjectsList
    • So it's defined as a constant, but I think it might be accessible on client if they try hard enough
  • Use in /projects/:id
    • Use in ProjectsList
    • Use in /dashboard
  • Use in /forum/posts/:id
    • Use in /forum

@koolskateguy89 koolskateguy89 linked an issue Dec 2, 2022 that may be closed by this pull request
@koolskateguy89 koolskateguy89 marked this pull request as ready for review December 2, 2022 14:39
@koolskateguy89 koolskateguy89 marked this pull request as draft December 2, 2022 14:40
@koolskateguy89 koolskateguy89 self-assigned this Dec 2, 2022
@koolskateguy89 koolskateguy89 marked this pull request as ready for review December 2, 2022 15:32
@koolskateguy89 koolskateguy89 merged commit de99ba7 into main Dec 2, 2022
@koolskateguy89 koolskateguy89 deleted the hashids branch December 2, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use hashids to mask IDs in URL
1 participant