Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GN-5088: add LMB table configs for the RMW IV #736

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

elpoelma
Copy link
Contributor

@elpoelma elpoelma commented Oct 21, 2024

Overview

This PR adds LMB-table configs for the 'Installatievergadering' of the 'Raad van maatschappelijk welzijn'.
Specifically, it adds configs for the following dynamic tables:

  • 'Zetelverdeling van de BSCD (Bijzonder comite voor de sociale dienst)'
  • 'Kandidaat-leden BSCD'
  • 'Verkiezing leden BCSD' (this one contains the mandaat:bekrachtigdAanstellingVan annotations)
  • 'Geloofsbrieven leden BSCD'
  • 'Eedaflegging leden BCSD'

As you'll notice while testing this PR, some of these tables have empty cells which we can't derive/automatically fill-in based on LMB.

connected issues and PRs:

GN-5088

Setup

None

How to test/reproduce

  • You'll need to test this PR logged in as an OCMW
  • Create a new IV
  • Add the necessary (configured with the new RMW tags) LMB tables in any AP (the second is the legally correct one)
  • Test the sync flow
  • Ensure the tables are filled in with sensible data on the previous legislation

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@elpoelma elpoelma added the enhancement New feature or request label Oct 21, 2024
@elpoelma elpoelma self-assigned this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant