Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GN-4977: add meeting details modal to inauguration meeting creation flow #697

Merged
merged 10 commits into from
Aug 28, 2024

Conversation

elpoelma
Copy link
Contributor

@elpoelma elpoelma commented Aug 12, 2024

Overview

This PR adds a meeting details modal to the inauguration meeting creation flow to allow users to specify the location and time of the meeting.
Differences compared to common meeting creation modal:

  • Administrative unit is not editable
  • Modal title is slightly different

Additionally, this PR also includes a modification in how the governing body (bestuurseenheid) is selected for the inauguration meeting:

  • The binding-einde should be undefined or gte than the current date. (is this correct?)
connected issues and PRs:

GN-4977

How to test/reproduce

  • Start the app
  • Visit the meeting inbox
  • Test if both the common meeting and inauguration meeting creation flows works as expected

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@elpoelma elpoelma added the enhancement New feature or request label Aug 12, 2024
Copy link
Contributor

@lagartoverde lagartoverde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Getting this error that doesn't seem to affect the functionality, otherwise works good

app/routes/inbox/meetings/new.js Outdated Show resolved Hide resolved
@elpoelma
Copy link
Contributor Author

image Getting this error that doesn't seem to affect the functionality, otherwise works good

Ah that could be caused by this: duetds/date-picker#87

@elpoelma
Copy link
Contributor Author

image Getting this error that doesn't seem to affect the functionality, otherwise works good

#705 should fix the issue

@abeforgit abeforgit merged commit 1a32e46 into master Aug 28, 2024
3 checks passed
@abeforgit abeforgit deleted the GN-4977-meeting-details-modal branch August 28, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants