Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Modelica Tough coupling user guide #3696

Open
wants to merge 47 commits into
base: master
Choose a base branch
from

Conversation

JayHuLBL
Copy link
Contributor

No description provided.

@JayHuLBL JayHuLBL self-assigned this Mar 11, 2024
@JayHuLBL
Copy link
Contributor Author

@EttoreZ Would you please take another look at the changes?

@EttoreZ
Copy link
Contributor

EttoreZ commented Mar 11, 2024

Hey @JayHuLBL just two quick comments:

  • In the doStep description of the UserGuide. I would comment/remove this line: os.system("./writeincon < writeincon.inp") and uncomment this line # write_incon(), and also remove this line os.system(" ./readsave < readsave.inp > out.txt") and uncomment this line # readsave(). This is because the Python script now does not rely on the Fortran utility programs anymore.
  • The second comment is also related to that. In the diagram where you show the workflow of the Python script, writeincon and readsave are cited as utility programs. I would change that to Python functions.
    Apart from those, everything else looks good to me.

@JayHuLBL
Copy link
Contributor Author

@EttoreZ Thanks for the comments. I just addressed it. Please double-check.

@EttoreZ
Copy link
Contributor

EttoreZ commented Mar 12, 2024

@JayHuLBL the changes look good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants