Issue2884 pid autotuning #3590
Issue2884 pid autotuning #3590
Conversation
| @@ -93,7 +93,9 @@ block FirstOrderAMIGO | |||
| Buildings.Controls.OBC.Utilities.PIDWithAutotuning.Relay.Controller rel( | |||
| final yHig=yHig, | |||
| final yLow=yLow, | |||
| final deaBan=deaBan) "Relay controller" | |||
| final deaBan=deaBan, | |||
| reverseActing=reverseActing) | |||
| {-70,-6},{-70,26},{-62,26}}, color={0,0,127})); | ||
| connect(conErr.u2, u_s) annotation (Line(points={{-62,14},{-90,14},{-90,0},{-120, | ||
| 0}}, color={0,0,127})); | ||
| if reverseActing then |
There was a problem hiding this comment.
should not have the if else in the equation section. We only allow the connect statement.
To enable or disable the connection, you can add a CDL.Reals.MultiplyByParameter instance (with k=1) and make the instance conditional. This will enable/disable the connection.
There was a problem hiding this comment.
I made two components for comparing the reference and the measurement, which are enabled/disenabled based on reverseActing and removed the if else in the equation section.
| @@ -131,15 +147,17 @@ boolean relay switch output <code>yOn</code>, and the control error | |||
| </p> | |||
| <ul> | |||
| <li> | |||
| <code>yErr = u_s - u_m</code>, | |||
| <code>yErr = u_m - u_s</code>, | |||
There was a problem hiding this comment.
It would be better to change the documentation as:
- if the parameter
reverseActing = false, then,yErr = u_m - u_s,- if yErr < -deaBan and trigger is true, ...
- if ...
- ...
- else if the parameter
reverseActing = true, then,yErr = u_s - u_m,- if yErr < -deaBan and trigger is true, ...
- if ...
- ...
There was a problem hiding this comment.
As suggested, the model doc is updated.
| @@ -0,0 +1,150 @@ | |||
| within Buildings.Controls.OBC.Utilities.PIDWithAutotuning.Validation; | |||
| model DirectActingPIDWithFirstOrderAMIGO | |||
There was a problem hiding this comment.
We may change the class name in the validation package as:
DirectActingPID, DirectActingPI, ReverseActingPID, ReverseActingPI.
There was a problem hiding this comment.
As suggested, I changed the names but keep WithFirstOrderAMIGO as other system models may be added in the future.
| @@ -0,0 +1,215 @@ | |||
| within Buildings.Fluid.HeatExchangers.Examples; | |||
| model WetCoilCounterFlowPControlAutoTuning | |||
There was a problem hiding this comment.
It seems that the controller did not control the measured value to the set point:
There was a problem hiding this comment.
I feel it is not caused by the PI controller. Please see the results from running Buildings.Fluid.HeatExchangers.Examples.WetCoilCounterFlowPControl
@JayHuLBL could you please kindly take a look at it?