Issue3544 heat pump rtu controls #3545
Open
+9,795
−483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ldings into junkewang001-RTUdevelopment
Rt udevelopment
Control modules updates for RTU Development
…trols Issue3544 heat pump rtu controls
…nkewang001/modelica-buildings into issue3544_HeatPumpRTUControls
Issue3544 heat pump rtu controls
…trols Issue3544 heat pump rtu controls
Issue3544 heat pump rtu controls
JayHuLBL
reviewed
May 13, 2024
| @@ -0,0 +1,606 @@ | |||
| within Buildings.Examples.VAVReheat.BaseClasses; | |||
| partial model HVAC_Interface | |||
| "Partial model of variable air volume flow system with terminal reheat that serves five thermal zones" | |||
There was a problem hiding this comment.
update the comment. The partial model is not just used for the VAV system.
JayHuLBL
reviewed
May 13, 2024
| Modelica.Fluid.Interfaces.FluidPort_b portHeaTerRet(redeclare package Medium = | ||
| MediumW) "Terminal heat loop return" annotation (Placement( | ||
| transformation(extent={{490,-310},{510,-290}}), | ||
| iconTransformation(extent={{310, |
JayHuLBL
reviewed
May 13, 2024
| input Modelica.Units.SI.Power PCooSen "Sensible cooling energy"; | ||
| input Modelica.Units.SI.Power PCooLat "Latent cooling energy"; | ||
|
|
||
| Real EFan( |
JayHuLBL
reviewed
May 13, 2024
| <a href=\"modelica://Buildings.Examples.VAVReheat.Guideline36\"> | ||
| Buildings.Examples.VAVReheat.Guideline36</a>. | ||
| </p> | ||
| </html>", revisions="<html> |
There was a problem hiding this comment.
update the revision note. is it a new model?
JayHuLBL
reviewed
May 13, 2024
| color={0,0,127})); | ||
|
|
||
| for i in 1:nCoiCoo loop | ||
| connect(CooCoi[i].TOut,TOut) |
JayHuLBL
reviewed
May 13, 2024
| @@ -0,0 +1,227 @@ | |||
| within Buildings.Examples.VAVReheat.BaseClasses; | |||
| partial model PartialHVAC_DXSystems | |||
| "Partial model of variable air volume flow system with terminal reheat that serves five thermal zones" | |||
JayHuLBL
reviewed
May 13, 2024
| @@ -0,0 +1,159 @@ | |||
| within Buildings.Examples.VAVReheat; | |||
| model Guideline36_DXSystems | |||
There was a problem hiding this comment.
Run the model gives warning as:
Also, it takes more than 10 minutes to finish the simulation, while for Guideline36.mo it takes 18 seconds.
JayHuLBL
requested changes
May 13, 2024
There was a problem hiding this comment.
@karthikeyad-pnnl Please see inline comments. The example model Guideline36_DXSystems.mo takes unexpected long time to finish the simulation. Please double check if there is any bug.
|
@karthikeyad-pnnl Is there update on this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR for merging heat pump RTU control modules.
@JayHuLBL Can you please create a development branch for merging this branch? Thanks!