Issue3327 spawn pthp development #3328
Open
+40,287
−1,903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR to update branch with latest master
…nd process their results
… record with one that has updated UA calculations. Changed damper opening and zone mixing volume pressure to closely mirror EPlus values
…el to use X_input for zone volume. Added new model with no X_input for zone volume. Updated mos scripts for both files
…to issue2886_fanCoilModel
Issue2886 fan coil model
…source cooling coils
…pment Xing heating coil development
…ting_renameCooledSource
…buildings into terrancelu92-spawn_development
karthikeyad-pnnl
changed the base branch from
master
to
issue3288_dxCoilHeating_renameCooledSource
Unit test for PTHP package
karthikeyad-pnnl
changed the base branch from
issue3288_dxCoilHeating_renameCooledSource
to
issue3288_dxCoilHeating
|
@JayHuLBL I am creating this PR to merge the files for the packaged terminal heat pump system model, which uses the new DX heating coil we have implemented. I have currently set the base branch to be the DX heating coil development branch. Can we please create a new development branch on lbl-srg/modelica-buildings for the PTHP system model? I will then edit my PR to point to that new branch. Thanks! -Karthik |
|
@karthikeyad-pnnl I just created the development branch |
karthikeyad-pnnl
changed the base branch from
issue3288_dxCoilHeating
to
issue3327_SPAWN_PTHdevelopment
|
@karthikeyad-pnnl : Karthik to resolve conflicts, then Michael to merge but not yet review until templates are added by Karthik. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.