Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change format of log messages in C to identify time and model #2317

Closed
mwetter opened this issue Dec 23, 2020 · 2 comments · Fixed by #2332
Closed

Change format of log messages in C to identify time and model #2317

mwetter opened this issue Dec 23, 2020 · 2 comments · Fixed by #2332
Assignees
@mwetter
Labels
spawn Development for Spawn of EnergyPlus

Comments

@mwetter
Copy link
Member

mwetter commented Dec 23, 2020

This issue is to change the format of the diagnostic messages written in the C code to display the time and model name. This will allow easier reading and filtering during debugging.
@mwetter mwetter added the spawn Development for Spawn of EnergyPlus label Dec 23, 2020
@mwetter mwetter self-assigned this Dec 23, 2020
mwetter added a commit that referenced this issue Dec 23, 2020
@mwetter
Reformatted log messages for #2317
202a468 
[ci skip]
@mwetter
Copy link
Member Author

mwetter commented Jan 11, 2021

Note that in constructor calls, time cannot be reported (as it is not known).
From https://specification.modelica.org/master/functions.html:

The constructor shall initialize the object, and must not require any other calls to be made for the initialization to be complete (e.g., from an initial algorithm or initial equation).

mwetter added a commit that referenced this issue Jan 19, 2021
@mwetter
Cleaned up code for #2317
93a95cc
mwetter added a commit that referenced this issue Jan 19, 2021
@mwetter
Cleaned up code for #2317
7269aa7
mwetter added a commit that referenced this issue Jan 19, 2021
@mwetter
Cleaned up code for #2317
e194f4f
mwetter added a commit that referenced this issue Jan 19, 2021
@mwetter
Cleaned up code for #2317
b2ebcc9
@mwetter
Copy link
Member Author

mwetter commented Jan 19, 2021 •
edited
Loading

Todo:

  • Create and test windows binaries

@mwetter mwetter mentioned this issue Jan 19, 2021
Merged
mwetter added a commit that referenced this issue Jan 20, 2021
@mwetter
Issue2317 spawn logging (#2332)
ec8f3d2 
* Reformatted log messages for #2317

[ci skip]

* Regenerated fmus

* Set c flags

* Clean up to avoid compiler warnings from C

* Removed use of initialTime in constructor

From the Modelica Standard: 'The constructor shall initialize the object, and must not require any other calls to be made for the initialization to be complete (e.g., from an initial algorithm or initial equation).' [ci skip]

* Corrected write statement

* Cleaned up code for #2317

* Cleaned up code for #2317

* Cleaned up code for #2317

* Removed declaration that is already in base class

* Cleaned up code for #2317

* Set optimization

* Removed log level assignment

* Updated Linux binaries

* Corrected type of log level

This was needed for MS

* Changed type of logLevel to int

* Set release as default

* Regenerated binaries

* Replaced with files from master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mwetter mwetter

Labels
spawn Development for Spawn of EnergyPlus
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue2317 spawn logging lbl-srg/modelica-buildings
1 participant
@mwetter