Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable Travis CI #11

Merged
merged 4 commits into from
Feb 13, 2017
Merged

enable Travis CI #11

merged 4 commits into from
Feb 13, 2017

Conversation

bplimley
Copy link
Contributor

Closes #5

@bplimley
Copy link
Contributor Author

Travis CI is free for public repos. Private repos are allowed a 100-build trial period.

Right now I'm only running for Python 2.7 and 3.6, and only on master branch. I'm not sure if each version counts as a separate build or not. Regardless, we can do more once we go public.

@bplimley
Copy link
Contributor Author

Also, it failed and I don't have time to figure it out right now.

@bplimley
Copy link
Contributor Author

bplimley commented Feb 1, 2017

travis-ci/travis-ci#2650 ...

@bplimley
Copy link
Contributor Author

bplimley commented Feb 1, 2017

Yay, Travis says our code works!

I put in a try/except to bypass the spectrum file plotting, which throws a tkinter.TclError error on Travis because there is no $DISPLAY. At some point we should revise those tests to check the spectra without requiring a visual check, and if we still want plotting in the tests then we should find a more elegant workaround. (I thought about importing tkinter and except tkinter.TclError but in python 2 the package is Tkinter and in python 3 it's tkinter and I decided it wasn't worth going through the import complications...)

Copy link
Member

@markbandstra markbandstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@markbandstra markbandstra merged commit 87895f7 into master Feb 13, 2017
@markbandstra markbandstra deleted the travis branch February 13, 2017 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants