New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SIGFPE on small number of overlaps #63

Open

jchorl wants to merge 1 commit into lbcb-sci:master from jchorl:josh/debug

jchorl commented Dec 24, 2021

Greetings,

I found that with a small number of overlaps, logger_step = overlaps.size() / RACON_LOGGER_BIN_SIZE will yield 0.

This causes a divide-by-zero:

                        log_bar_idx = window_idx / logger_step;

Now, there are in-fact overlaps, so the code should still execute. Let me know what you think of the fix. We could also just use an if below.

fix

a849ff6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet