Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable GPU features in racon_wrapper #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Re-enable GPU features in racon_wrapper #53

wants to merge 1 commit into from

Conversation

schorlton
Copy link

@schorlton schorlton commented May 26, 2021 •
edited
Loading

I'm not exactly sure why but at some point (31a3c92), the GPU features got commented out of the racon_wrapper. This PR simply re-enables them by uncommenting them. I tested with --cudapoa-batches and seems to work.

@rvaser
Copy link
Collaborator

rvaser commented May 26, 2021 •
edited
Loading

Hello,
I will have to update CMake build in order to enable GPU options in wrapper, otherwise the wrapper breaks if racon was not build with GPU support. Not sure why we did not do that earlier, need to think if there is anything else problematic.

Best regards,
Robert

@rvaser rvaser added the enhancement New feature or request label May 26, 2021
@schorlton
Copy link
Author

I see. I guess I did not hit this as a compiled with GPU support.

@rvaser
Copy link
Collaborator

rvaser commented Jun 1, 2021

Can you please try out the latest commit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schorlton @rvaser