-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prework for multiple chargers per cs #1480
Open
drc38
wants to merge
16
commits into
main
Choose a base branch
from
mult
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
45980bb
Allow multiple chargers per cs
drc38 000e81d
improve multidevice logic
drc38 9288018
add config entry migration
drc38 6cdbe8d
fix translations
drc38 f45b4ff
fix service tests and unloading
drc38 86fe7f7
fix config migration when keys missing
drc38 932f7f4
Merge branch 'main' into mult
drc38 7f64d42
minor tidy ups
drc38 a28db5b
fix id refs and add cp_id as identifier
drc38 c5713a7
add minor version
drc38 9b1fa68
add minor_version to tests
drc38 c51ad1a
remove change of dr name
drc38 dabd569
fix up tests
drc38 85360de
prevent entry duplicates
drc38 6c32421
register services to cpid
drc38 5fb4b05
Revert "register services to cpid"
drc38 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review and test the migration logic thoroughly
The
async_migrate_entry
function is critical for migrating configuration entries from version 1 to version 2. Ensure that all possible scenarios are handled, including edge cases where users might downgrade or have incomplete data.Consider adding comprehensive unit tests to cover the migration process. This will help identify any potential issues and ensure a smooth transition for users.
Would you like assistance in creating tests for the migration logic?
🧰 Tools
🪛 GitHub Check: codecov/patch
[warning] 144-144: custom_components/ocpp/init.py#L144
Added line #L144 was not covered by tests