Feat/cli lib #159
Open
Feat/cli lib #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR essentially implements the library aspect of the cli crate (moved stuff from main.rs to other 'modules'/'files'). So now it can be used in other crates (pretty much as a glorified+centralized builder for a sage run).
As far as I know ... the api is the same in terms of what structs exist and what fields are there but I did change the visibility of some of them.
(I also sneaked in a small refactor that moves the format identification from the cli crate to the cloudpathlib crate ... sorry ...)
LMK what you think!