Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#24 updated the README for newly added Basic Auth parameters #25

Merged
merged 1 commit into from
Jan 15, 2019
Merged

#24 updated the README for newly added Basic Auth parameters #25

merged 1 commit into from
Jan 15, 2019

Conversation

gheibia
Copy link
Contributor

@gheibia gheibia commented Jan 15, 2019

No description provided.

lawrencegripper
lawrencegripper approved these changes Jan 15, 2019
View reviewed changes
Copy link
Owner

@lawrencegripper lawrencegripper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for not only adding your options but also fixing up the formatting and errors. LGTM

@lawrencegripper lawrencegripper merged commit 3e689e5 into lawrencegripper:master Jan 15, 2019
@gheibia
Copy link
Contributor Author

gheibia commented Jan 15, 2019

You're welcome!

@gheibia gheibia deleted the fb/24_document_update branch January 15, 2019 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lawrencegripper lawrencegripper lawrencegripper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gheibia @lawrencegripper