Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Healthcheck credential parameters #23

Merged
merged 3 commits into from
Jan 14, 2019
Merged

Healthcheck credential parameters #23

merged 3 commits into from
Jan 14, 2019

Conversation

gheibia
Copy link
Contributor

@gheibia gheibia commented Jan 11, 2019

Added 2 optional parameters for username and password to be used whilst calling Traefik's "/health" endpoint.
This is useful when Traefik's API endpoint ("/health" included) is protected with Basic Auth.

@gheibia
lawrencegripper#22 added 2 optional parameters for username and passw…
c94201a 
…ord to be used whilst calling Traefik's /health endpoint. This is useful when Traefik's API endpoint (/health included) is protected with Basic Auth.
@gheibia
lawrencegripper#22 extracting the common string literals into untyped…
5b069f7 
… string constants
@gheibia
Copy link
Contributor Author

gheibia commented Jan 11, 2019 •
edited
Loading

It's not immediately clear to me from the CI logs what went wrong with the build.

To test this locally, I simply run ./build.sh and ensure all tests pass and binaries are generated. I also manually launch the app and test it.

Running ci.sh locally fails, as well. However, if I update the base image to golang:1.11.4-alpine, build succeeds.

lawrencegripper
lawrencegripper approved these changes Jan 14, 2019
View reviewed changes
Copy link
Owner

@lawrencegripper lawrencegripper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks for adding the additional tests for the change and sorry about the build error.

@lawrencegripper lawrencegripper merged commit a7e73a9 into lawrencegripper:master Jan 14, 2019
@gheibia
Copy link
Contributor Author

gheibia commented Jan 14, 2019

Thank you.

@gheibia gheibia deleted the fb/22_healthcheck_credentials branch January 14, 2019 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lawrencegripper lawrencegripper lawrencegripper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gheibia @lawrencegripper