Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AppliedEnergistics.xml #167

Closed
wants to merge 1 commit into from
Closed

Update AppliedEnergistics.xml #167

wants to merge 1 commit into from

Conversation

Baughn
Copy link

@Baughn Baughn commented Nov 17, 2016

Fixes #166

I feel like it might be breaking a lot of other things, though. The .ini file in Sprocket doesn't quite match. But oh well, I'm sure you can figure it out.


This change is Reviewable

@lawremi
Copy link
Owner

lawremi commented Nov 17, 2016

What do you mean by the ini file not quite matching?

@ghost
Copy link

ghost commented Nov 17, 2016

Actually, the values placed there ("x * default * apenCertusQuartzWhatever") were specifically placed to ensure that Certus Quartz would not over- or under-populate in reference to the vanilla settings. It's not a good idea to replace the numbers with "default", as that would wipe out the ore's spawn balance. The name change makes sense, however.

If you need the original INI file to build against, you can get it here.

@Baughn
Copy link
Author

Baughn commented Nov 17, 2016

Right. Can those factors not be added to the .ini?

@ghost
Copy link

ghost commented Nov 17, 2016

They can, and in the original ini, they have. If you use that file as the default to start tweaking, you can fix the ores without breaking the balance. From what I can tell of your example, all you need to do is change the "Blocks:" line for both distributions.

@Baughn
Copy link
Author

Baughn commented Nov 18, 2016

Ahh. I used the "Blank" one; didn't spot Standard.

This one should be good.

@Baughn Baughn reopened this Nov 18, 2016
@lawremi
Copy link
Owner

lawremi commented Nov 19, 2016

The changes look good, but they should really happen at the Sprocket ini level, so that we can continue to batch autogenerate the XML files.

@Baughn
Copy link
Author

Baughn commented Nov 19, 2016

There wasn't an 1.10 branch of Sprocket, though. Is 'master' it?

@ghost
Copy link

ghost commented Nov 19, 2016

Yes. I "snapshot" the different versions of things. Once it was obvious 1.2.26 was the last one to be released for 1.7.10, I snapshotted Sprocket, and now am setting up the master for 1.10. Considering that I don't really play 1.10, however, I'm trusting others to actually test these things.

@ghost
Copy link

ghost commented Nov 19, 2016

Additionally, I've already updated Applied Energistics, so if you can get a copy and test it, it should work correctly.

@lawremi
Copy link
Owner

lawremi commented Dec 6, 2016

Should be fixed via #169.

@lawremi lawremi closed this Dec 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants