Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ECDSA signing support #95

Merged
merged 1 commit into from
Jun 8, 2018
Merged

Add ECDSA signing support #95

merged 1 commit into from
Jun 8, 2018

Conversation

eoger
Copy link
Contributor

@eoger eoger commented Jun 2, 2018

Related to #42.

Copy link
Owner

@lawliet89 lawliet89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far.

One change: can you document how to generate a ECDSA key pair in the documentation for JWA please.

@lawliet89 lawliet89 merged commit bf4b07b into lawliet89:master Jun 8, 2018
axos88 pushed a commit to axos88/biscuit that referenced this pull request Jul 23, 2018
@eoger eoger deleted the ecdsa branch March 6, 2019 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants