Fix the jwk field (.web_key) to contain a proper JWK #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allow(unknown_lints) is now sufficient.
Into is blanket implemented anyway, this now allows .from() as well. Fixes the remaining Clippy lint in nightly.
|
Thanks for the PR. On the one hand I am wondering if we should add a generic type to support additional parameters in the JWK. On the other hand it'll make the types become really unwiedly. I'll merge this in first and see if there is any feedback in the future about supporting more generics. |
lawliet89
approved these changes
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The jwk field was unusable prior to this change; a string was not valid in this context.