Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for JWK thumbprints (RFC 7638) #156

Merged
merged 4 commits into from
Jul 17, 2020
Merged

Add support for JWK thumbprints (RFC 7638) #156

merged 4 commits into from
Jul 17, 2020

Conversation

g2p
Copy link
Contributor

@g2p g2p commented Jul 12, 2020

No description provided.

@g2p g2p force-pushed the jwk-thumbprint branch from 97e9864 to ecd14a3 Compare July 12, 2020 08:14
@g2p
Copy link
Contributor Author

g2p commented Jul 12, 2020 •
edited
Loading

(Let me add extra test vectors before merging)

Done.

@g2p g2p force-pushed the jwk-thumbprint branch from 566469d to 44f80be Compare July 12, 2020 08:49
@lawliet89 lawliet89 self-assigned this Jul 13, 2020
@lawliet89
Copy link
Owner

Thanks for your contribution! Let me look into this slightly later this week.

lawliet89
lawliet89 reviewed Jul 13, 2020
View reviewed changes
src/jwk.rs Outdated Show resolved Hide resolved
src/jwk.rs Outdated Show resolved Hide resolved
src/jwk.rs Show resolved Hide resolved
@g2p
Copy link
Contributor Author

g2p commented Jul 13, 2020

Thank you for the review! I'll try to get to it in a day or so.

g2p added 2 commits July 15, 2020 20:51
@g2p
Add a test for badly-normalized values
f6d8132 
This is for the RSA exponent case; other members / key types have not
been checked.
@g2p
JWK thumbprints: Hide ring from public API, expand documentation
238f3cd
@g2p
Copy link
Contributor Author

g2p commented Jul 16, 2020

I've hidden ring from the API and added more documentation, with a test for poorly normalized RSA and a doc test.

While hiding ring and adding notes about security, I took the opportunity to not expose SHA-1, which
I don't think is useful for thumbprints.

lawliet89
lawliet89 approved these changes Jul 17, 2020
View reviewed changes
Copy link
Owner

@lawliet89 lawliet89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the feature. I'll release a beta shortly with this included and another breaking change I want to make for a major release.

@lawliet89 lawliet89 merged commit eefe29b into lawliet89:master Jul 17, 2020
@lawliet89 lawliet89 added this to the v0.5.0 milestone Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lawliet89 lawliet89 lawliet89 approved these changes

Assignees

@lawliet89 lawliet89

Labels
enhancement
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@g2p @lawliet89