Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

namespace 'v8'; did you mean simply 'SetResourceConstraints' #208

Closed
wants to merge 1 commit into from

Conversation

konsumer
Copy link

@konsumer konsumer commented Feb 3, 2015

resolves #203, this error on build:

 CXX(target) Release/obj.target/fibers/src/fibers.o
../src/fibers.cc:140:3: error: no member named 'SetResourceConstraints' in
      namespace 'v8'; did you mean simply 'SetResourceConstraints'?
                v8::SetResourceConstraints(isolate, constraints);
                ^~~~~~~~~~~~~~~~~~~~~~~~~~
                SetResourceConstraints
../src/fibers.cc:139:7: note: 'SetResourceConstraints' declared here
        void SetResourceConstraints(Isolate* isolate, ResourceConstraint...
             ^
1 error generated.

@laverdet
Copy link
Owner

laverdet commented Feb 4, 2015

Not actually that simple. See comments on #205

Further testing is required.

@laverdet laverdet closed this Feb 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build fails on io.js 1.0.2
2 participants