Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUILD: Edits to build configuration, moved maps out of PAK files #224

Merged
merged 5 commits into from
Nov 8, 2024

Conversation

Zungrysoft
Copy link
Collaborator

Description of Changes


  • Moved deathmatch maps out of PAK files in order to make setting up servers easier and allow players to delete/move conflicting bsp files.
  • Made build script not give a 'missing asset' warning for .lit files, since some of our maps don't have an associated .lit file.
  • Moved the engine-specific default.cfg files into PAK0.PAK to be with the regular default.cfg. We don't want the user editing these files anyway.

Checklist


  • I have read the LibreQuake contribution guidelines
  • I have thoroughly tested my changes to the best of my ability
  • I confirm I have not contributed anything that would impact LibreQuake's licensing and usage
  • This Pull Request fixes a critical issue that should be reviewed and merged as soon as possible

Copy link
Owner

@lavenderdotpet lavenderdotpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

lavenderdotpet

This comment was marked as resolved.

Copy link
Owner

@lavenderdotpet lavenderdotpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slight suggestion to the name of the pull request
not going to make it a request change since its not to important

id just suggest changing the title
to something that says that the maps are being moved

@Zungrysoft Zungrysoft changed the title BUILD: Edits to build configuration BUILD: Edits to build configuration, moved maps out of PAK files Nov 3, 2024
@lavenderdotpet
Copy link
Owner

looks good just needs a 2nd approvals

after this we should talk about moving the gpl assets to one of the 2 paks again
it's better to keep them separate
so maybe pop.lmp and progs.dat in pak0 and everything else in pak1

Copy link
Collaborator

@Nolcoz Nolcoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is good

@Zungrysoft Zungrysoft merged commit d0b000e into main Nov 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants