Log to specific event log file

[drjayvee]

Q	A
Fixed tickets	#309 #346

[PabloKowalczyk]

Hello @drjayvee, thanks for your PR!
Looks like CI is not happy, I saw you just added new code over 2.3.x branch, but you should use #346 as a base branch, then add your code and finally push it here (feel free to use force push, it's your fork anyway).
Sorry for that bureaucracy, but it is needed, hope you know it :)

[drjayvee]

Whoops, my previous branch actually didn't have @rrushton's changes at all. Must have happened while cherry-picking.

I now merged alisqi@f07569e (from #346) into 2.3.x.

[PabloKowalczyk]

Thanks, now better :) CI seems to be unhappy, one test fails and CS fixer reports some issues.

[drjayvee]

Regarding the PHPUnit test:

There was 1 error:

1) Crunz\Tests\EndToEnd\LoggerTest::test_event_logging_override
Error: Call to undefined method Crunz\Tests\EndToEnd\LoggerTest::assertFileDoesNotExist()

/home/runner/work/crunz/crunz/tests/EndToEnd/LoggerTest.php:60
/home/runner/work/crunz/crunz/vendor/phpunit/phpunit/phpunit:61

This works for me with the PHPUnit installed through composer.

Is this something I need to fix? Using assertTrue(is_file())?

[PabloKowalczyk]

Method assertFileDoesNotExist should be available in PHPUnit, what is installed version of PHPUnit?

[drjayvee]

For me:

../vendor/bin/phpunit --version
PHPUnit 9.5.4 by Sebastian Bergmann and contributors.

But the Code_Checks uses PHPUnit 8.5.15, which does fit composer.json.

[PabloKowalczyk]

You are right, PHPUnit 8.5 is required on PHP 7.2 and it is also installed on "prefers lowest" jobs.
Could you add assertFileDoesNotExist method to \Crunz\Tests\TestCase\PolyfillAssertTrait with file_exists check? With this code will be forward compatible.

[drjayvee]

Hi @PabloKowalczyk, sorry for taking so long again, but here you go!

[PabloKowalczyk]

Almost there :) One case failed in CI, it's related to CSFixer.

[PabloKowalczyk]

Sorry, now PHPStan reports some issues.

[drjayvee]

There we go. I should have probably tried running those tools locally as best as I can.

[PabloKowalczyk]

There is composer crunz:cs-fix and composer phpstan:check shortcuts for this, but make sure you have Symfony at v4.4 (same as in CI).
CI still fails, now CSFixer issue.

[drjayvee]

Hm,

$ composer crunz:cs-fix
> @php vendor/bin/php-cs-fixer fix --diff -v --ansi
Could not open input file: vendor/bin/php-cs-fixer
Script @php vendor/bin/php-cs-fixer fix --diff -v --ansi handling the crunz:cs-fix event returned with error code 1

Should php-cs-fixer be composer required perhaps?

[PabloKowalczyk]

Should php-cs-fixer be composer required perhaps?

It is, but only in require-dev section.

PR merged, thanks @drjayvee.

[drjayvee]

It is, but only in require-dev section.

I don't see it!

PR merged, thanks @drjayvee.

Thanks a lot for the fresh release. Also, thanks to @rrushton for the actual code!

[flippedbits]

Thanks @drjayvee for seeing this through!