Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement logger factory rfc #298

Merged
merged 20 commits into from
Apr 15, 2020
Merged

Implement logger factory rfc #298

merged 20 commits into from
Apr 15, 2020

Conversation

PabloKowalczyk
Copy link
Collaborator

Q A
Fixed tickets #259

@PabloKowalczyk PabloKowalczyk added this to the v2.2 milestone Apr 13, 2020
@PabloKowalczyk PabloKowalczyk mentioned this pull request Apr 13, 2020
Closed
@PabloKowalczyk
Add default configuration in test "Environment"
6fd98a5
@PabloKowalczyk
Add "\Crunz\Tests\TestCase\TemporaryFile::contents" method
b4a7dd2
@PabloKowalczyk
Add return type hint to "\Crunz\Tests\TestCase\TemporaryFile::filePat…
1382c82 
…h" method
@PabloKowalczyk
Check file exists in "\Crunz\Tests\TestCase\TemporaryFile::changePerm…
71f9600 
…issions"
@PabloKowalczyk
Add "\Crunz\Tests\TestCase\Faker" class
70acbca
@PabloKowalczyk
Add "\Crunz\Infrastructure\Psr\Logger\PsrStreamLogger" class
51af2f5
@PabloKowalczyk
Remove redundant comments in "EventRunner"
1db0c9a
@PabloKowalczyk
Make creating logger in "EventRunner" lazy
ec847ed
@PabloKowalczyk
Make sure user can call "publish:config" without configured timezone
6515eb3
@PabloKowalczyk
Add "\Crunz\Application\Service\LoggerFactoryInterface"
f2c3380
@PabloKowalczyk
Add "\Crunz\Infrastructure\Psr\Logger\PsrStreamLoggerFactory" as a "\…
13127d0 
…Crunz\Application\Service\LoggerFactoryInterface" implementation
@PabloKowalczyk
Use "ConfigurationInterface" in "LoggerFactoryInterface"
2b1316c
@PabloKowalczyk
Fix code blocks type and PHP syntax in README
a1bc48d
@PabloKowalczyk
Add "logger_factory" configuration option
0186c68
@PabloKowalczyk
Add "FailTasks" to tests' resources
84f2991
@PabloKowalczyk
Add support for custom LoggerFactory
59ed199
@PabloKowalczyk
Document setting up custom logger
120e891
@PabloKowalczyk
Remove "monolog/monolog" dependency
31fc7e8
@PabloKowalczyk
Fix issues reported by PHPStan
8dcecbe
@PabloKowalczyk
Try to close resources pointing to "TemporaryFile" on destruct
a137d20
@PabloKowalczyk PabloKowalczyk merged commit 3f7c8f5 into lavary:master Apr 15, 2020
@PabloKowalczyk PabloKowalczyk deleted the implement-logger-factory-rfc branch April 15, 2020 05:14
This was referenced Apr 15, 2020
Closed
Closed
Closed
Closed
@PabloKowalczyk PabloKowalczyk mentioned this pull request Jun 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.2
Development

Successfully merging this pull request may close these issues.
1 participant
@PabloKowalczyk