-
-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to ignore empty context in monolog #233
Conversation
Could you add end-to-end test which will test added behavior? |
Looking closer at this, it doesn't look like any of the logging currently uses the context parameter anyways. Would it be simpler to just default the |
It is tempting to make |
Yeah I think that would be fine. On a related note, what do you think of the idea of a simple custom log format config option. Then in the crunz.yml someone could do something like:
|
We can go for it for |
Yes I can provide a PR |
@rrushton do you need some help with this PR? |
Apologies, work has been very busy and I have not had a chance to get back to this. |
Merged manually in 75ba071, thanks @rrushton. |
Added the option to allow ignoring of empty context when writing to monolog. I reason for this is to slim down the number of lines the logging produces and the double [] [] monolog is writing does not need to be there.