Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.x #118

Merged
merged 3 commits into from
Jun 15, 2018
Merged

1.x #118

merged 3 commits into from
Jun 15, 2018

Conversation

mindcreations
Copy link
Contributor

Fix for #41 on branch 1.x with requested test

@mindcreations
Copy link
Contributor Author

I see that with PHP v7.2 tests are not passing... it seems not a problem related with PHP version or the code itself... any ideas?

@PabloKowalczyk
Copy link
Collaborator

Coding style issues, run composer crunz:cs-fix in the project root.

@mindcreations
Copy link
Contributor Author

It seems that CI exceeded 10 minutes, maybe you have to extend the timeout value.

@PabloKowalczyk
Copy link
Collaborator

Seems to be issues related to Travis itself, not the code. Thanks @mindcreations for PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants