Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeneralRunConfig for Hardware-Based Config Selection #901

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kds300
Copy link
Contributor

@kds300 kds300 commented Dec 6, 2024

Issue Number: #900

Objective of pull request: Introduce GeneralRunConfig class which selects appropriate run config based on hardware parameter.

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

  • User must choose a specific RunConfig class for the hardware they wish to run on.

What is the new behavior?

  • User can select GeneralRunCfg and parameterize the hardware the network is run on.

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant