Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize msg passing folder for development #292

Merged
merged 10 commits into from
Aug 5, 2022
Merged

Initialize msg passing folder for development #292

merged 10 commits into from
Aug 5, 2022

Conversation

hexu33
Copy link
Contributor

@hexu33 hexu33 commented Aug 5, 2022

Issue Number: None

Objective of pull request: Initialize message passing infrastructure

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

None folder for refactoringing msg passing.

What is the new behavior?

  • Add cpp_message_infrastructure folder and initialize for developing the project

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

@hexu33 hexu33 requested review from killight98 and hongdami August 5, 2022 04:41
@killight98
Copy link

@hexu33 pls add namespace to each h/cc files as following:

namespace XXXX
{

}

@hexu33
Copy link
Contributor Author

hexu33 commented Aug 5, 2022

@hexu33 pls add namespace to each h/cc files as following:

namespace XXXX
{

}

Is msg_passing OK? Or could you suggest any name else? Do we need sub-namespace?

@killight98
Copy link

@hexu33 pls add namespace to each h/cc files as following:

namespace XXXX
{

}

Is msg_passing OK? Or could you suggest any name else? Do we need sub-namespace?

or lava_msg_passing?
@hongdami do u have any suggestion?

@hexu33
Copy link
Contributor Author

hexu33 commented Aug 5, 2022

@hexu33 pls add namespace to each h/cc files as following:

namespace XXXX
{

}

@hexu33 hexu33 closed this Aug 5, 2022
@hexu33 hexu33 reopened this Aug 5, 2022
@hexu33 hexu33 merged commit bceccfc into lava-nc:messaging_refactor_develop Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants