Skip to content
This repository has been archived by the owner on Sep 13, 2023. It is now read-only.

Export to carbon-sh #67

Merged
merged 2 commits into from
Mar 14, 2019
Merged

Export to carbon-sh #67

merged 2 commits into from
Mar 14, 2019

Conversation

matfire
Copy link
Contributor

@matfire matfire commented Mar 10, 2019

I added an icon (a picture icon) beside each note that, when clicked, will open up a new browser window pointing to an instance of https://carbon.now.sh containing the code from the note.

@lauthieb
Copy link
Owner

Wow thanks @matfire for this PR. I will try it pretty soon!

@lauthieb
Copy link
Owner

lauthieb commented Mar 14, 2019

@matfire it works pretty fine, thanks a lot!
Can you just please add this at line 70 of NoteCard.scss please:

#export-carbon {
   color: $dark;

   &:hover {
     color: lighten($black, 20%);
   }
}

I would like to keep the same behavior than #copy-file. Thanks :)

@matfire
Copy link
Contributor Author

matfire commented Mar 14, 2019

@lauthieb Thanks!

It is done.

@lauthieb
Copy link
Owner

Thank you @matfire
I will create a v1.2.2 this weekend 🎉

@lauthieb lauthieb merged commit 7ca686b into lauthieb:master Mar 14, 2019
@lauthieb
Copy link
Owner

Released in 1.2.2! 🎉
https://github.com/lauthieb/code-notes/releases/tag/1.2.2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants