Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding support for widget.definition.metadata #33

Merged
merged 1 commit into from
Dec 14, 2020

Conversation

yuriabrito
Copy link
Contributor

Why?

Datadog Dashboards might have an array of metadata inside widget.definition. Right now, this is being translated into

metadata: [[Object object]]

The correct way is to create many metadata elements with their respective content inside widget.definition.

How?

Describe your solution and any technical decisions you made

UI Changes

Screenshots of the change

Before

metadata: [[Object object]]

After

metadata {
  expression = "some_expression"
  alias_name = "some_alias"
}

Copy link
Owner

@laurmurclar laurmurclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, thanks so much for this!

I'll publish an update today but it might take a few hours/days to get approved by Chrome & Firefox 😊

@laurmurclar laurmurclar merged commit 71dbbbf into laurmurclar:master Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants