Fix bugs in bound handling #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dag-erling
force-pushed
the
des/bad-bounds
branch
2 times, most recently
from
8dbc127 to
8b673d3
Compare
According to POSIX, the correct error to return when a bound count exceeds `RE_DUP_MAX` is `REG_BADBR`, not `REG_BADPAT`.
If no maximum count was given, `max == -1`, so `min` can be legitimately greater than `max`, and it is not sufficient to only check that `max` does not exceed `RE_DUP_MAX`.
Signed integer overflow is undefined behavior, so use unsigned long internally while parsing numbers, and substitute INT_MAX at the end if overflow occurred.
dag-erling
force-pushed
the
des/bad-bounds
branch
from
8b673d3 to
f4dd24c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #55.