Fix bug when building without alloca #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `tre_match()`, there is a spot where we check if the provided source is capable of rewinding, and return if it isn't. Due to missing braces, that return becomes unconditional when `TRE_USE_ALLOCA` is false. As a result, calling `regexec()` with a regex that includes back references always fails with `REG_BADPAT`. Fixes: 6f09108
dag-erling
force-pushed
the
des/no-alloca-bug
branch
from
0125d78 to
8fcd44f
Compare
|
Yes, this is exactly the problem and fix I described. |
|
How would you prefer this to be merged? All three options look reasonable to me, and my git knowledge is not enough to say which might be better. |
trushworth
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
tre_match(), there is a spot where we check if the provided source is capable of rewinding, and return if it isn't. Due to missing braces, that return becomes unconditional whenTRE_USE_ALLOCAis false. As a result, callingregexec()with a regex that includes back references always fails withREG_BADPAT.