Desktop: Fixes #3628: Add scroll offset for dragging notes while scrolled down #3643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hile scrolled down The note draging was not taking into account the scroll distance. This caused the notes to be dragged to a different location than the mouse. This scroll offset should fix that issue.
|
Thanks for the fix, that looks good. Unfortunately I've refactored the NoteList component in the coming UI update, so I prefer to wait till this is ready before merging your pull request, as it will be easier to fix the conflict at that time. |
|
@laurent22 Do you want me to try to fix it in the ui-update branch instead of here? |
If you could do that, that would be perfect. I assume it's a matter of copying your fix to the new .tsx component. |
|
I created another pull request for the ui_update branch. |
|
Closing in favour of #3651 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The note dragging was not taking into account the scroll distance.
This caused the notes to be dragged to a different location than the mouse.
This scroll offset should fix that issue.