Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch for rename events in the external editor and re-watch file #1659

Merged
merged 1 commit into from
Jun 19, 2019

Conversation

CalebJohn
Copy link
Collaborator

Fixes the gedit issue from the forums
I'm a bit wary adding in a change like this, but it doesn't seem to introduce any issues on my machine.
This was added based on a chokidar issue at some point I think chokidar will be fixed and this bit of code can be removed.

I tested this with gedit and gvim, it fixes the issue for both.

I think this also fixes #1614 but it might need more testing.

@tessus tessus added desktop All desktop platforms linux labels Jun 16, 2019
@laurent22
Copy link
Owner

Thanks for looking into it @CalebJohn. I'll give it a try on Windows and confirm.

@laurent22 laurent22 merged commit b461625 into laurent22:master Jun 19, 2019
@laurent22
Copy link
Owner

Thanks for the fix @CalebJohn, it works good.

@CalebJohn CalebJohn deleted the watch-rename branch June 19, 2019 23:46
@void-m4110c
Copy link

void-m4110c commented Oct 29, 2020

I still have said error with gvim as external editor.

Since upgrading to the new version this is broken.

1.) When I edit files and save, the new text is not reflected in Joplin (but after save + close it appears)
2.) When I go on writing after I saved the first time (without closing), everything since the first write/save action is lost.

I tried this with both Windows / Linux and Versions 1.2.6 and 1.3.9

Additionally, after creating situation 2 (writing on after saving) on Linux, the Joplin App crashes and I have to kill it (in version 1.3.9)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop All desktop platforms linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ExternalEditWatcher displays incorrect status
4 participants