Desktop: Fixes #11335: Markdown editor: Auto-close backticks #11351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit auto-matches ` characters. Previously, `closeBrackets` was specified incorrectly (wrong type), which seems to have prevented bracket matching from taking place. Note: While this behavior change is a regression on desktop, it isn't on mobile. If this change is backported to release-3.1, it may make sense to not apply this change to mobile.
personalizedrefrigerator
changed the title
personalizedrefrigerator
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit auto-matches "`" characters. Previously,
closeBracketswas specified incorrectly (wrong type), which seems to have prevented bracket matching from taking place.This change affects both mobile and desktop.
Fixes #11335.
Note
This pull request targets
release-3.1.On mobile, "auto-match brackets" is always disabled. As such, this pull request should only affect desktop.
Testing plan
Web:
)is added.Desktop:
)is added.