Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Upgrade to Electron 32.2.0 #11200

Conversation

personalizedrefrigerator
Copy link
Collaborator

Summary

This pull request upgrades to Electron 32.2.0.

Potentially related: #11199.

Relevant breaking changes

See also https://www.electronjs.org/docs/latest/breaking-changes.

UI Changes

The Chromium-provided UI for menus has changed on Linux and Windows:

Before After
screenshot: View menu has square corners screenshot: View menu has rounded corners and slightly larger items
screenshot: Menu has square corners and is roughly the height of the screen (this is the edit menu) screenshot: Menu has rounded corners and doesn't all fit on one screen
Windows:
screenshot: Existing Joplin view menu
Windows
screenshot: Joplin view menu, slightly thinner and taller

Manual testing

Linux (Fedora 40):

  • Printing:
    • Ran File > Print and printed to PDF.
    • Attached the resultant PDF to a note and verified that it rendered.
  • Media attachments:
    • Attached a video and an audio file to a note.
    • Verified that both can play.
    • Verified that the video can fullscreen.

Windows 11:

  • Verified that the automated Playwright tests run successfully (they aren't run on Windows in CI).
  • Attached an audio file to a note. Verified that it can play.

@JGCarroll
Copy link

There's an unfortunate regression upstream with the file picker portals, which benefit the Snap and Flatpak releases primarily for sandbox mediation; but are also the mechanism of how Electron uses e.g., the KDE filepicker for users who dislike the GTK filepicker.

electron/electron#43819

There's no workaround and ultimately the underlying framework can't be held back for relatively minor things, but I thought I'd raise this as it's a sneaky breaking change.

Ideally, Electron would support the existing API and the newer one, as no distribution even has the V4 API with it being in beta, and stable releases will never backport it, meaning this basically just breaks for every existing user.

@laurent22
Copy link
Owner

So should we wait before merging this?

@JGCarroll
Copy link

I'd personally say no, the regressions are unfortunate but I'd imagine that either upstream will revert down the line when feedback happens, or they'll stick to it and then there's no point in holding back given the underlying Chromium/Node stuff needs to be kept up to date to avoid worse problems down the line.

It just means from a support POV, there might be questions relating to file pickers that seem out of the blue. For example, people are happy to see that in Gnome 47, the file picker has full thumbnail support. Electron 29 would be able to use this, but Electron 32 will instead go back to GTK3's internal file picker and lose it, until users upgrade to newer distributions (which staggers years at a time).

Ultimately I hope they just revert it.

@laurent22 laurent22 merged commit c6d319e into laurent22:dev Oct 26, 2024
10 checks passed
@JGCarroll
Copy link

The linked issue suggests that Electron will revert the file picker change in a future patch release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants