Desktop, Mobile: Downgrade CodeMirror packages to fix various Android regressions #11170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
personalizedrefrigerator
changed the title
personalizedrefrigerator
changed the title
personalizedrefrigerator
added a commit
to personalizedrefrigerator/joplin
that referenced
this pull request
Oct 16, 2024
This commit upgrades most `@codemirror/` packages, like laurent22#11034, but disables the EditContext API (see laurent22#11170).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This reverts commit 5a07b79 due to a crash when using the SwiftKey keyboard to input text on Android (codemirror/dev#1450). Based on the upstream issue, this seems related to CodeMirror's switch to using the EditContext API, which seems to have significant issues on Android+Chromium.
Edit: This should also fix a missing "Select All" context menu item.