Mobile: Fixes #11130: Fix regression: Search screen not hidden when cached for search result navigation

[personalizedrefrigerator]

Summary

This pull request fixes a regression related to refactoring done in a recent pull request — the search results screen was not hidden when its visible prop was set to false. This happened after clicking on a search result and resulted in a split layout.

This pull request copies the approach used by screens/Notes.tsx — styling the search screen with flex: 0.001 when marked with visible: false and setting inert={true} to prevent accessibility navigation. This is similar to the logic used prior to the refactoring.

Fixes #11130.

Screen recordings

Android + TalkBack

search-bugfix.webm

Shows:

1. Opening search with an existing query.
2. Activating a search result.
   • The search screen is correctly hidden.
3. Clicking back navigates back to the search result screen.
4. Activating another search result.
   • The search screen is correctly hidden.
5. TalkBack focus is moved from the title to the edit button.

Web + Chromium

Screencast.from.2024-09-26.15-47-55.webm

Shows:

1. Opening search with an existing query.
2. Activating a search result.
3. Navigating to a different note from the result.
4. Pressing the back arrow.
   • Navigates back to the first note.
5. Pressing the back arrow.
   • Navigates back to the search screen.
6. Opening a different search result.
7. Pressing the back arrow.
   • Navigates back to the search screen.
8. Pressing the back arrow.
   • Navigates back to the note list.

[personalizedrefrigerator]

See the similar logic in Notes.tsx:

joplin/packages/app-mobile/components/screens/Notes.tsx

Line 243 in 90640e5

rootStyle.flex = 0.001; // This is a bit of a hack but it seems to work fine - it makes the component invisible but without unmounting it

...and the equivalent logic in search.tsx prior to the refactoring:

joplin/packages/app-mobile/components/screens/search.tsx

Line 178 in f772cc5

rootStyle.flex = 0.001; // This is a bit of a hack but it seems to work fine - it makes the component invisible but without unmounting it

[mrjo118]

I'm not able to view or download the first video. Are you saying that pressing a search result showing the note in split screen is a bug rather than a new feature? My presumption was that it was a feature to making looking through multiple search results easier

[personalizedrefrigerator]

Are you saying that pressing a search result showing the note in split screen is a bug rather than a new feature? My presumption was that it was a feature to making looking through multiple search results easier

It's a bug. However, I do think that having the ability to see search results at the same time as the note preview pane is useful, particularly on large-screen devices.

I'm not able to view or download the first video.

Edit: I've just converted it from a .mp4 to a .webm. Previously, the first video was a .mp4 encoded with ffmpeg and the second was a .webm captured by Ubuntu's (GNOME's) screen recorder.