Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Accessibility: Fix multi-note selection menu not tab-focusable #11018

Conversation

personalizedrefrigerator
Copy link
Collaborator

Summary

This pull request fixes an accessibility bug — previously, selecting multiple notes in the sidebar, then pressing tab had no effect (despite the presence of a menu).

This issue is fixed by removing an unnecessary tab override. Previously, pressing tab from the note list 1) prevented the default browser handling of the tab key and 2) tried to focus the note title input regardless of whether it was visible.

Notes

  • To avoid a regression, additional focus/blur selection logic is added. Without it, refocusing the title input with the tab key would select the title input's content, rather than restore the cursor location.
  • For now, the shift-tab override remains.

Testing plan

  1. Ensure that several to-dos and notes are visible in the note list.
  2. Focus a note in the note list.
  3. Press tab.
  4. Verify that the note title has focus and that the cursor is at the end of the input.
  5. Focus the note list by pressing shift-tab.
  6. Select multiple notes using shift and the arrow keys.
  7. Verify that the note selection menu is visible.
  8. Press tab.
  9. Verify that the note selection menu has focus.
  10. Select just one note.
  11. Press tab.
  12. Verify that the note title is focused. Select the first letter.
  13. Press shift-tab, then tab.
  14. Verify that focus is restored to the first character.

This has been tested successfully on MacOS Sonoma.

@personalizedrefrigerator personalizedrefrigerator changed the title Desktop: Accessibility: Fix note selection menu not tab-focusable Desktop: Accessibility: Fix multi-note selection menu not tab-focusable Sep 9, 2024
@personalizedrefrigerator personalizedrefrigerator added desktop All desktop platforms accessibility Related to accessibility labels Sep 9, 2024
@laurent22 laurent22 merged commit 147a66d into laurent22:dev Sep 10, 2024
10 checks passed
@personalizedrefrigerator
Copy link
Collaborator Author

Related to #10795.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Related to accessibility desktop All desktop platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants