Desktop: Accessibility: Fix multi-note selection menu not tab-focusable #11018
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes an accessibility bug — previously, selecting multiple notes in the sidebar, then pressing tab had no effect (despite the presence of a menu).
This issue is fixed by removing an unnecessary tab override. Previously, pressing tab from the note list 1) prevented the default browser handling of the tab key and 2) tried to focus the note title input regardless of whether it was visible.
Notes
Testing plan
This has been tested successfully on MacOS Sonoma.