Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Migrate SQL queries in preparation for web support #10670

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Jul 1, 2024

Summary

This pull request's goal is to simplify #10650 by moving SQL query-related changes into a separate pull request.

Why?

Supporting double quotes for string literals is considered nonstandard in SQLite. In SQLite ≥ 3.41.0, using double quotes for strings is disabled by default.1

See this issue in another project and these notes in the SQLite documentation.

Testing plan

This pull request currently relies on existing automated tests to verify correctness.

Note: #10650 includes these changes. With that pull request, it has been verified that, in the web client,

  • Tags can be added to a note.
  • It's possible to search for text using full text search.
  • It's possible to sync with Dropbox and Joplin Server.
  • It's possible to select and delete multiple notes to the trash, then restore those notes from the trash.

Footnotes

  1. https://www.sqlite.org/quirks.html#double_quoted_string_literals_are_accepted

This pull request's goal is to simplify laurent22#10650 by moving SQL
query-related changes into a separate pull request.
@laurent22 laurent22 merged commit d89be23 into laurent22:dev Jul 1, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants