-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Desktop: Add OneNote Importer #10642
Conversation
…lib' into add-onenote-parser-lib
@laurent22 We talked about using an absolute path instead of a relative for the SVG extraction to remove an error message, but by using the absolute path when I tried to import the HTML to Joplin the absolute path images weren't imported to Joplin as resource, I guess to be imported they need to be relative. I end up just using I also added the documentation needed. |
Sorry Pedro, there's a conflict now on Root.tsx. Once this is fixed we can merge |
This reverts commit b248700. We need to find a solution to make building the Rust package optional
Summary
I'm adding a new package library that will be used to convert OneNote exports into Joplin Notes.
The onenote-converter is based on the implementations found in:
https://github.com/msiemens/one2html
https://github.com/msiemens/onenote.rs
We will be compiling the Rust code to wasm with the package
wasm-pack
to output a Node package that can be imported in our codebaseWhat is missing at this point:
onenote-converter
package (described bellow).run_ci.sh
(changed to debug)yarn dist
process (make sure the package is always build there)How the package is being integrated
Now Rust is a requirement, the message that is visible when Rust is not installed in the developer machine:
Error message
Message that shows when you try to run yarn build from the package without having Rust: