Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When printing sync target info to the log, filter the data #9985

Closed
laurent22 opened this issue Feb 23, 2024 · 3 comments · Fixed by #10014
Closed

When printing sync target info to the log, filter the data #9985

laurent22 opened this issue Feb 23, 2024 · 3 comments · Fixed by #10014
Labels
desktop All desktop platforms enhancement Feature requests and code enhancements good first issue

Comments

@laurent22
Copy link
Owner

laurent22 commented Feb 23, 2024

Currently during sync, the full sync info is printed to the log. It contains a lot of unnecessary information and should be filtered out:

  • masterKeys_: The content and checksum properties should be removed
  • ppk_.value.privateKey: The first 20 characters and last 20 characters should be kept, and the rest removed (replaced by "...")
  • ppk_.value.publicKeyKeep the first 40 characters
@laurent22 laurent22 added enhancement Feature requests and code enhancements desktop All desktop platforms good first issue labels Feb 23, 2024
@Sanket-0510
Copy link

I understood the issue, but I am not able to find where have we defined sync Info schema, also when you are talking about the log where are you pointing exactly?

@Nainish-Rai
Copy link

ppk_.value.privateKey: The first 20 characters and last 20 characters should be kept, and the rest removed (replaced by "...")
ppk_.value.privateKeyKeep the first 40 characters

I am having confusion do you want to keep first 40 characters or the first point??

@Gurpreetk9
Copy link

ppk_.value.privateKey: The first 20 characters and last 20 characters should be kept, and the rest removed (replaced by "...")
ppk_.value.privateKey:Keep the first 40 characters

I think one of them shoul be ppk_.value.publicKey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop All desktop platforms enhancement Feature requests and code enhancements good first issue
Projects
None yet
4 participants