Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark certain plugins as unsupported on mobile #10360

Closed
personalizedrefrigerator opened this issue Apr 23, 2024 · 1 comment · Fixed by #10376
Closed

Mark certain plugins as unsupported on mobile #10360

personalizedrefrigerator opened this issue Apr 23, 2024 · 1 comment · Fixed by #10376
Assignees
Labels
bug It's a bug mobile All mobile platforms plugins Anything related to Joplin's plugin system

Comments

@personalizedrefrigerator
Copy link
Collaborator

Operating system

iOS

Joplin version

3.0.2

Desktop version info

No response

Current behaviour

At present, it's possible to install all plugins on mobile, even though many don't work. It's currently possible to mark plugins as desktop-only with the platforms manifest key. At present, however, no plugins do this (based on searching pluginData.json for the platforms key).

Expected behaviour

Plugins that don't work on mobile should be marked as such.

Logs

No response

@personalizedrefrigerator personalizedrefrigerator added bug It's a bug mobile All mobile platforms plugins Anything related to Joplin's plugin system labels Apr 23, 2024
@personalizedrefrigerator
Copy link
Collaborator Author

personalizedrefrigerator commented Apr 23, 2024

The existing manifestOverrides file could be used to add "platforms": ["desktop"] to some of the more popular plugins that only support desktop. Ideally, however, if a plugin author later adds "platforms": ["desktop","mobile"] to the manifest of a plugin that previously was desktop-only, it would be marked as compatible with mobile.

Here are a few options:

  1. Add a manifestDefaults.json or similar file that provides default manifest values for different plugins.
  2. Add plugin platforms to manifestOverrides.json and instruct plugin authors to open a pull request on the plugins repository when a plugin adds mobile support.
  3. Make all plugins last published earlier than some date default to desktop-only, make newer plugins default to supporting both desktop and mobile.

Option 2 should be easiest to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It's a bug mobile All mobile platforms plugins Anything related to Joplin's plugin system
Projects
None yet
1 participant